change catalog default warehouse location to not use hive-style warehouse location #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could do something fancy with |
3 tasks
kevinjqliu
force-pushed
the
kevinjqliu/remove-.db-suffix
branch
from
217d912 to
f393c38
Compare
kevinjqliu
changed the title
.db suffix in warehouse location.db suffix in warehouse location for dynamo/hive/glue catalogs
|
@jayceslesar made it so aligns with the java implementation |
Fokko
reviewed
Jun 8, 2025
| @@ -652,6 +654,19 @@ def _convert_dynamo_table_item_to_iceberg_table(self, dynamo_table_item: Dict[st | |||
| catalog=self, | |||
| ) | |||
|
|
|||
| def _get_default_warehouse_location(self, database_name: str, table_name: str) -> str: | |||
There was a problem hiding this comment.
Looks like we're repeating this a couple of times, should we move this into pyiceberg/catalog/__init__.py?
Fokko
approved these changes
Jun 13, 2025
kevinjqliu
changed the title
.db suffix in warehouse location for dynamo/hive/glue catalogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2052
Rationale for this change
Aligns catalog behavior with the java reference implementation.
HiveCatalog, DynamoDbCatalog, and GlueCatalog all use
.dbsuffix in warehouse locationJdbcCatalog, HadoopCatalog, and InMemoryCatalog do not use
.dbsuffix in warehouse locationAre these changes tested?
Yes tests for sql catalog are modified to remove
.dbAre there any user-facing changes?