Support Filters on Top-Level Struct Fields #1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srilman
commented
Mar 22, 2025
| @@ -925,7 +926,7 @@ def primitive_fields() -> List[NestedField]: | |||
| ] | |||
|
|
|||
|
|
|||
| def test_add_top_level_primitives(primitive_fields: NestedField) -> None: | |||
| def test_add_top_level_primitives(primitive_fields: List[NestedField]) -> None: | |||
There was a problem hiding this comment.
Fixing a typing error I noticed. The type of the fixture was incorrect.
Fokko
pushed a commit
that referenced
this pull request
Apr 25, 2025
Closes #1778. # Rationale for this change Current, filters that are applied to the top-level struct column do not work. For example, given a table of schema: ``` table { 2: id: optional int 1: data: required string 3: location: struct<5: latitude: optional float, 6: longitude: optional float> } ``` We want to support applying filters to field `location`, such as `location is not null`. Note that filters like `location == {"latitude": ..., "longitude": ...}` wont work right now, but can be equivalently rewritten to `location.latitude == ... and location.longitude == ...`. # Are these changes tested? Yes, tests were added at both the schema level and table reads. # Are there any user-facing changes? Support some basic filters on struct columns at the top-level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1778.
Rationale for this change
Current, filters that are applied to the top-level struct column do not work. For example, given a table of schema:
We want to support applying filters to field
location, such aslocation is not null. Note that filters likelocation == {"latitude": ..., "longitude": ...}wont work right now, but can be equivalently rewritten tolocation.latitude == ... and location.longitude == ....Are these changes tested?
Yes, tests were added at both the schema level and table reads.
Are there any user-facing changes?
Support some basic filters on struct columns at the top-level.