Include DELETE entries when inspecting #1731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While doing some checks, I've noticed that these are missing.
kevinjqliu
reviewed
Feb 27, 2025
There was a problem hiding this comment.
There are 2 more instances of .fetch_manifest_entry call.
One in partitions, another in _files
I think we should make the same change to the _files, not so sure about partitions
That's funny, was thinking the other way around. For |
|
oops youre right. definitely not needed in |
Fokko
added a commit
that referenced
this pull request
Apr 25, 2025
While doing some checks, I've noticed that these are missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some checks, I've noticed that these are missing.