feat: add base config implementation #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowing design ideas from Velox.
wgtmac
reviewed
May 6, 2025
wgtmac
reviewed
May 9, 2025
|
What about renaming the title to |
yingcai-cy
changed the title
wgtmac
approved these changes
May 9, 2025
lidavidm
approved these changes
May 10, 2025
test/config_test.cc
Outdated
|
|
||
| enum class TestEnum { VALUE1, VALUE2, VALUE3 }; | ||
|
|
||
| std::string enumToString(const TestEnum& val) { |
There was a problem hiding this comment.
Suggested change
| std::string enumToString(const TestEnum& val) { | |
| std::string EnumToString(const TestEnum& val) { |
nit
test/config_test.cc
Outdated
| } | ||
| } | ||
|
|
||
| TestEnum stringToEnum(const std::string& val) { |
There was a problem hiding this comment.
Suggested change
| TestEnum stringToEnum(const std::string& val) { | |
| TestEnum StringToEnum(const std::string& val) { |
nit
zhjwpku
approved these changes
May 11, 2025
test/config_test.cc
Outdated
| template <typename T> | ||
| using Entry = const ConfigBase<TestConfig>::Entry<T>; | ||
|
|
||
| inline static const Entry<std::string> STRING_CONFIG{"string_config", "default_value"}; |
There was a problem hiding this comment.
nit: maybe we should follow the k-prefix pattern for static const variables.
lidavidm
approved these changes
May 12, 2025
Fokko
approved these changes
May 12, 2025
There was a problem hiding this comment.
Looks good @yingcai-cy Thanks for working on this. Thanks @wgtmac, @lidavidm and @zhjwpku for the review 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce a new config class to manage configurable options following design ideas from Velox