feat: add ExpireSnapshots as concrete class #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
force-pushed
the
ExpireSnapshots
branch
7 times, most recently
from
bfd5280 to
e1f179b
Compare
zhjwpku
reviewed
Nov 29, 2025
src/iceberg/test/CMakeLists.txt
Outdated
| literal_test.cc | ||
| predicate_test.cc) | ||
|
|
||
| add_iceberg_test(update_test SOURCES ../update/test/expire_snapshots_test.cc) |
Collaborator
There was a problem hiding this comment.
nit: I think this test file should be placed under src/iceberg/test/update/
shangxinli
force-pushed
the
ExpireSnapshots
branch
from
e1f179b to
36755e3
Compare
Add ExpireSnapshots as a concrete implementation in iceberg/update/
following the PendingUpdate pattern.
Features:
- Fluent API builder methods: ExpireSnapshotId, ExpireOlderThan,
RetainLast, DeleteWith, SetCleanupLevel
- Extends PendingUpdateTyped<vector<shared_ptr<Snapshot>>>
- Takes Table* in constructor for access to table metadata
- Placeholder implementations for Apply() and Commit()
Directory structure:
- src/iceberg/update/expire_snapshots.{h,cc}
- src/iceberg/update/CMakeLists.txt
- src/iceberg/update/meson.build
- Updated build files (CMakeLists.txt, meson.build)
Add comprehensive test suite for ExpireSnapshots API. Tests cover: - Fluent API chaining - ExpireSnapshotId single and multiple - ExpireOlderThan timestamp-based expiration - RetainLast to keep recent snapshots - DeleteWith custom deletion callback - SetCleanupLevel with different levels (None, MetadataOnly, All) - Combined configuration scenarios Test file location: src/iceberg/test/update/expire_snapshots_test.cc
shangxinli
force-pushed
the
ExpireSnapshots
branch
from
36755e3 to
66809ae
Compare
zhjwpku
approved these changes
Nov 30, 2025
src/iceberg/table.h
Outdated
| /// \brief Create a new expire snapshots operation for this table | ||
| /// | ||
| /// \return a shared pointer to the new ExpireSnapshots operation | ||
| virtual std::shared_ptr<ExpireSnapshots> NewExpireSnapshots(); |
Change Table::NewExpireSnapshots() and Transaction::NewExpireSnapshots() to return std::unique_ptr instead of std::shared_ptr for consistency with other factory methods (NewScan, NewTransaction) that create new objects with exclusive ownership transfer to the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ExpireSnapshots as a concrete implementation extending PendingUpdateTyped, following Gang's suggestion to avoid pure interfaces when there's only one implementation.
Changes:
This design provides:
Full implementation of Apply() and Commit() will be added in follow-up PRs.