HIVE-28728: fix STR_TO_MAP() returning garbled utf-8 characters when vectorization is enabled #6559
Open
cyanzheng2926 wants to merge 2 commits into
Open
HIVE-28728: fix STR_TO_MAP() returning garbled utf-8 characters when vectorization is enabled #6559cyanzheng2926 wants to merge 2 commits into
cyanzheng2926 wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
This PR is proposed for HIVE-28728, when under non-UTF8 default charset, STR_TO_MAP() returns garbled characters with vectorization enabled.
Why are the changes needed?
Using default non-UTF8 charset should not give different behaviours (garbled characters vs correct characters) when vectorization is on/off.
This also aligns with the Jira HIVE-28544.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Created str_to_map_utf8.q and tested with TestMiniTezCliDriver TestMiniLlapCliDriver with corresponding settings