HIVE-29521: Unit tests TestTimestampTZ, TestTimestampTZWritable fail due to different JDK locale#6388
Merged
soumyakanti3578 merged 2 commits intoMar 31, 2026
Conversation
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
…due to different JDK locale
hemanthumashankar0511
force-pushed
the
timestamp_failures_fix
branch
from
426f55e to
ba1f154
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
…due to different JDK locale
|
Contributor
Author
|
@soumyakanti3578 Could u please merge this !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR stabilizes the static FORMATTER in TimestampTZUtil.java by explicitly setting its locale to Locale.US.
Changes:
Added import java.util.Locale;.
Updated FORMATTER initialization to use builder.toFormatter(Locale.US) instead of the default toFormatter().
Why are the changes needed?
The changes are required to fix a DateTimeParseException observed in "Canary" and modern CI environments (JDK 17/21).
Without an explicit locale, DateTimeFormatter falls back to the system's default locale. In certain environments specifically those using the CLDR (Unicode Common Locale Data Repository) provider—the default locale's rules for parsing timezone identifiers can lead to "greedy" matching. This causes the parser to match the "UTC" string and stop, leaving the offset (e.g., +08:00) as unparsed text, resulting in a failure at index 23.
Hardcoding Locale.US ensures that the parsing logic is deterministic and consistent across all developer machines and build servers, regardless of their local system configuration.
Does this PR introduce any user-facing change?
No. This is an internal fix for parsing consistency. The behavior for users remains the same, but the reliability of parsing existing timestamp formats is improved across different server locales.
How was this patch tested?
The patch was verified using the following steps:
Reproduction: Confirmed that org.apache.hadoop.hive.common.type.TestTimestampTZ fails when running with the CLDR provider enabled:
mvn test -Dtest=TestTimestampTZ -DargLine="-Djava.locale.providers=CLDR"
Verification: Confirmed that after adding Locale.US, the tests pass successfully under the same CLDR provider settings.
Regression: Verified TestTimestampTZWritable (in serde) passes to ensure no serialization regressions.