Skip to content

HIVE-29272: Query-based MINOR compaction should not consider minOpenWriteId #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+1 −2
Closed

HIVE-29272: Query-based MINOR compaction should not consider minOpenWriteId #6134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd6c1ae
HIVE-29272: Query-based MINOR compaction should not consider minOpenW…
kuczoram Oct 16, 2025
74909fd
Merge branch 'apache:master' into HIVE-29272
kuczoram Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,9 @@ private void buildAddClauseForAlter(StringBuilder query) {
query.setLength(0);
return; // avoid NPEs, don't throw an exception but return an empty query
}
long minWriteID = validWriteIdList.getMinOpenWriteId() == null ? 1 : validWriteIdList.getMinOpenWriteId();
long highWatermark = validWriteIdList.getHighWatermark();
List<AcidUtils.ParsedDelta> deltas = dir.getCurrentDirectories().stream().filter(
delta -> delta.isDeleteDelta() == isDeleteDelta && delta.getMaxWriteId() <= highWatermark && delta.getMinWriteId() >= minWriteID)
delta -> delta.isDeleteDelta() == isDeleteDelta && delta.getMaxWriteId() <= highWatermark)
.collect(Collectors.toList());
if (deltas.isEmpty()) {
query.setLength(0); // no alter query needed; clear StringBuilder
Expand Down