[feature] Add pagination and name-based search functionality in notification module #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hree lists in the notification module.
|
hi，Do I need to resubmit a PR to resolve conflicts? @tomsun28 |
no, just resolve conflicts on your own branch, and push it. |
Thank you, I'll give it a try. |
# Conflicts: # hertzbeat-alerter/src/main/java/org/apache/hertzbeat/alert/service/NoticeConfigService.java # hertzbeat-alerter/src/test/java/org/apache/hertzbeat/alert/service/NoticeConfigServiceTest.java # web-app/src/app/routes/alert/alert-notice/alert-notice-rule/alert-notice-rule.component.ts
hi, fix the checkstyle error pls |
hi,It should work now. |
tomsun28
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hree lists in the notification module.
What's changed?
Add pagination and name-based search functionality to the three lists: Notice Receiver, Notice Policy, and Notice Template.
Because some of the notification templates are predefined and cannot use the database's pagination functionality, a dropdown option has been added to the frontend page to distinguish between system predefined templates and custom templates.
Checklist
Add or update API