Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug fix #2853

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

A bug fix #2853

wants to merge 5 commits into from

Conversation

TJxiaobao
Copy link
Contributor

What's changed?

a small change.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.17%. Comparing base (1fe70a6) to head (ab4ab58).

Files with missing lines Patch % Lines
.../collector/collect/database/JdbcCommonCollect.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2853      +/-   ##
============================================
- Coverage     32.19%   32.17%   -0.02%     
  Complexity     1914     1914              
============================================
  Files           507      507              
  Lines         18663    18666       +3     
  Branches       2273     2274       +1     
============================================
- Hits           6008     6006       -2     
- Misses        11949    11953       +4     
- Partials        706      707       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ZY945 ZY945 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "jdbc: h2: mem:" should be "jdbc:h2:mem:"

@TJxiaobao
Copy link
Contributor Author

maybe "jdbc: h2: mem:" should be "jdbc:h2:mem:"

OK, this way of writing is the problem that I have not considered enough, I will correct it now, thank you for your correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants