-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[task] optimize okhttp3 connection factory #2539
base: master
Are you sure you want to change the base?
[task] optimize okhttp3 connection factory #2539
Conversation
Signed-off-by: aias00 <[email protected]>
manager/src/main/java/org/apache/hertzbeat/manager/config/RestTemplateConfig.java
Outdated
Show resolved
Hide resolved
I found this depend the httpclient5, there also have httpclient 4.5.14, okhttp in the system, suggest we unify them and use only one |
okay,i will fix them later |
hi, how about i submit another pr, and unify the httpcliens version in that pr; cause this modification will effect many codes |
okay👍👍, this seem effect many components. |
btw, I found only Line 89 in 361e573
maybe we can use httpclient instead in our project. spring has given up on okhttp, spring-projects/spring-framework#30919 @Aias00 cc @tomsun28 |
…ion_factory' into feature/optimize_okhttp3_connection_factory
@tomsun28 hi, i tried to degrade the httpclient 5 to httpclient 4. but the truth is that spring-web:6.1.4 would not support httpclient 4 anymore. so i think we can do that changed later, or i can see whether we can upgrade all httpclient4 to httpclient5 |
hi, the influxdb-java library has binding okhttp , we can not change that now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi, yes, maybe we can upgrade httpclient4 to httpclient5 later |
it seem need to unify the httpclient version
Signed-off-by: aias00 <[email protected]>
What's changed?
optimize okhttp3 connection factory, link #2528
Checklist
Add or update API