[Improve] add alarm define slience unit test #2426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
…zbeat into 0731-yuluo/fetch-3
tomsun28
changed the title
tomsun28
reviewed
Aug 2, 2024
Comment on lines
116
to
119
| Page<AlertDefine> alertDefinePage = alertDefineService.getAlertDefines(specification, pageRequest); | ||
| return ResponseEntity.ok(Message.success(alertDefinePage)); | ||
| Page<AlertDefine> alertDefinePages = new PageImpl<>(alertDefinePage.getContent(), pageRequest, alertDefinePage.getTotalElements()); | ||
|
|
||
| return ResponseEntity.ok(Message.success(alertDefinePages)); |
There was a problem hiding this comment.
hi why new a pageImpl to replace pre one here
There was a problem hiding this comment.
The problem is due to the fact that it causes errors during testing, and I also found the same problem in another test class, so I did it this way
but I didn't find out what the exact cause of the problem was, but this does fix the test questions. 😢
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
|
This pr relationship is confusing and I will reopen a pr. pls see #2454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.