[feature] add alibaba cloud oss support #1999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM!👍 please wait for days, we will merge it after new release. |
tomsun28
reviewed
Jun 12, 2024
Comment on lines
+202
to
+206
| <dependency> | ||
| <groupId>com.aliyun.oss</groupId> | ||
| <artifactId>aliyun-sdk-oss</artifactId> | ||
| <version>${alibaba.oss.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
hi, can we use http api instead of aliyun sdk, the sdk will import many irrelevant dependencies may also cause compatibility issues between dependency packages and licenses. See https://github.com/apache/hertzbeat/tree/master/material/licenses. We plan to remove the dependency on the cloud service SDK like aliyun, tencent, huawei sdk later.
There was a problem hiding this comment.
ok，we can change it
|
@asd108908382 Please address the dependency conflict issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API