fix(ci): let ci check go-lint and remove go-lint in Dockerfile#21
fix(ci): let ci check go-lint and remove go-lint in Dockerfile#21yexuanyang wants to merge 5 commits intoapache:mainfrom
Conversation
In additional, fix the typo errors in Dockerfile
|
hi The Dockefile has been restored to its previous state. Please check it again. Additionally, I think golint should be placed after go test and build because they have a sequence relationship. For example, after golint is executed, test and build are performed. Placing it as a linter seems inappropriate. WDYT? |
|
Yeah, you are right! Put the golint before go test and go build in workflow |
|
I see the go-lint action is commented now, are there some reasons? hertzbeat-collector-go/.github/workflows/build-and-test.yml Lines 26 to 35 in d627247 |
emm~ maybe because it has many lint error? |
| ARG GOPROXY | ||
| # ENV GOPROXY ${GOPROXY:-direct} | ||
| # ENV GOPROXY=https://proxy.golang.com.cn,direct | ||
| ENV GOPROXY ${GOPROXY:-direct} |
In additional, fix the typo errors in Dockerfile. I remove the unused tool
golangci-lint.