-
Notifications
You must be signed in to change notification settings - Fork 9k
HADOOP-19555. Fix testRenameFileWithFullQualifiedPath on Windows #7654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 +1 overall
This message was automatically generated. |
1292957
to
eba3e10
Compare
Started the CI run for Windows - https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/905/. |
🎊 +1 overall
This message was automatically generated. |
slfan1989
approved these changes
Apr 28, 2025
ayushtkn
approved these changes
Apr 28, 2025
goiri
approved these changes
Apr 28, 2025
The Windows CI run has finished. The test has passed -
Logs - archive.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The Apache Commons Net FTP library is used for
FTPFileSystem
. InTestFTPFileSystem#testRenameFileWithFullQualifiedPath()
, the FS operations (such as touch and rename) are made using absolute paths. However, the library expects relative paths.This caused
FTPFileSystem#getFileStatus()
to throwFileNotFoundException
since the library was trying to look for the absolute path under which the FileSystem was mounted.This worked fine on Linux as it just appended the absolute path under the FileSystem's mount path -

However, this fails on Windows since suffixing the absolute path under the FileSystem's mount path doesn't yield a valid path due to the drive letter in the absolute path.
Consider the following illustration -
On Linux
On Windows
So, to fix this, we need to treat the FS operations as purely relative.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?