GUACAMOLE-2005: FIlter out batches that ended up not having any keystroke events. #1039
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugen-keeper
approved these changes
Feb 24, 2025
aleitner
force-pushed
the
GUACAMOLE-2005-timestamp-bug
branch
from
c12b3dc to
cd6944c
Compare
necouchman
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps of key events within the “Keystroke Log” UI will sometimes show as “0:00”, even though there are no associated details displayed and such a timestamp would be in the past.
This is caused by batches that get created but end up not having any events completed within the
batchSeparationtime frame.