Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add list_metrics and list_metric_infos to the Python SemanticModelCatalog API, with a SemanticModelMetric result type and REST response decoding. Each call uses one schema-level request and preserves complete metrics, including Decimal precision.
Why are the changes needed?
Let Python clients discover metrics without loading each Semantic Model, following #14038 under #14036.
Depends on #14143. This draft includes prerequisite commits and needs rebasing after they merge.
Fixes #14146.
Does this PR introduce any user-facing change?
Adds two discovery methods with catalog-relative schema/model namespaces. Existing SemanticModelCatalog implementations retain compatible unsupported-operation defaults.
How was this patch tested?
138 Semantic Model unit tests and 14 real-server integration tests passed with H2, including discovery lifecycle, authorization, and Ossie regressions.
From clients/client-python:
Integration tests used GRAVITINO_HOME and START_EXTERNAL_GRAVITINO=true against the built server. Distribution build, Black, Pylint, and git diff --check passed.