Repository navigation
[Cherry-pick to branch-1.3] [#14062][#14063] fix(starrocks): Quote rename column names and skip empty alter clauses (#14064) - #14134
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…mpty alter clauses (#14064) ### What changes were proposed in this pull request? - Quote both column names in StarRocks rename column SQL. - Skip empty delete column clauses, and return an empty SQL when no change remains so no ALTER TABLE is sent. ### Why are the changes needed? Unquoted names break renames of special or reserved column names, and an empty `ALTER TABLE` is executed by StarRocks as a table OPTIMIZE. Fix: #14062, #14063 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Added unit tests in `TestStarRocksTableOperationsSqlGeneration`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick Information:
branch-1.3