Repository navigation
[Cherry-pick to branch-1.3] [#14031] fix(flink-connector): Validate credential providers for Iceberg non-REST backends (#14032) - #14132
Open
github-actions[bot] wants to merge 2 commits into
Conversation
…erg non-REST backends (#14032) ### What changes were proposed in this pull request? For Iceberg catalogs with a non-REST backend, the Flink connector now checks `credential-providers` when it opens the catalog: - `aws-irsa` is rejected, because its catalog-level credential is injected once and expires after `s3-token-expire-in-secs`. - `s3-token`, `gcs-token`, `adls-token`, `oss-token` and `cos-token` log a warning, because they vend nothing at catalog level and Iceberg falls back to the credentials on the Flink nodes. - REST backends are not affected. The docs now state that Flink only receives static credentials for non-REST backends, and that per-table refreshable credentials require a REST backend with `data-access=vended-credentials`. ### Why are the changes needed? The Flink connector fetches catalog-level credentials once and never refreshes them. With `aws-irsa`, jobs fail with `ExpiredToken` after about an hour; with the other token providers, Flink silently gets no credential, while the docs claim credentials are consumed automatically. Fix: #14031 ### Does this PR introduce _any_ user-facing change? Yes. Loading an Iceberg catalog with a Hive or JDBC backend and `aws-irsa` now fails in Flink. Token providers only log a warning. ### How was this patch tested? Added unit tests in `TestGravitinoIcebergCatalog`. # Conflicts: # docs/security/credential-vending.md # flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/iceberg/GravitinoIcebergCatalog.java
github-actions
Bot
added
cherry-pick
diqiu50
changed the title
diqiu50
removed
the
cherry-pick-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick Information:
branch-1.3