Repository navigation
Conversation
…dencies with buildHealth, warning only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Gravitino gets a per-module report of dependencies it uses without declaring, or declares without using, and a ratchet so the count can only go down. Nothing fails today.
warn. Plain-javamodules are analysed asapp();testFixturesis ignored.checkBuildHealthBaselinereads the JSON report and fails only if a module has more findings than its entry ingradle/build-health-baseline.json. A module missing from the file is allowed 0, so new modules start clean.updateBuildHealthBaselineregenerates it, so a cleanup PR is "fix, then lower the number".build-healthjob, parallel tobuildand behind the same path filter. It writes a per-module table (findings, baseline, over / at / below) to the job summary and uploads the reports.iceberg-rest-server-experimentwaits for thecopyDependstask it shares an output folder with.Why are the changes needed?
Modules compile against libraries they never declare, so a dependency upgrade can break them far away. Testcontainers 2 dropping
junit:junitis the recent example (#14105). Today nothing reports it. This makes it visible per module and stops it from growing, without blocking anyone.Part of #14106 (steps 1 and 2 of its plan).
Does this PR introduce any user-facing change?
No. Build and CI only.
How was this patch tested?
buildHealthandcheckBuildHealthBaselinepass onmain;help,spotlessCheckand RAT pass.