Repository navigation
[#14061] sub-task(web-v2): Support UI for tag assignment values - #14071
Open
LauraXia123 wants to merge 4 commits into
Open
LauraXia123 wants to merge 4 commits into
LauraXia123 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
4 open issues
This mapping makesvalueMode: 'none'andvalueMode: 'allowed'with an empty selection both… · New Usingkey={value}will produce duplicate React keys ifallowedValuescontains repeated strings,… · New The validator only checks max length; it currently allows empty/whitespace-only entries and… · New The helper text is a bit vague about the constraint. Consider clarifying that values are immutable… · New
What changed in this PR
Adds UI support for configuring a tag’s allowed assignment values (Any / None / Only these values) and displays immutable values for existing tags to address #14061.
Changes:
- Adds
valueModeandallowedValuesto the tag creation form state and submit payload mapping. - Introduces create-mode UI for selecting value mode and entering allowed values using tag input.
- Introduces edit-mode read-only display of the tag’s configured value rules.
| File | Description |
|---|---|
| web-v2/web/src/app/compliance/tags/CreateTagDialog.js | Adds form controls and submit mapping for tag allowed-values support, plus read-only display in edit mode. |
Review effort: Lite
Copilot stopped reviewing on behalf of
LauraXia123 due to an error
October 21, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
Why are the changes needed?
Fix: #14061
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually