Skip to content

[MINOR][CI] Stop unrelated PR comments from cancelling Delta and ANSI runs #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackylee-ch merged 7 commits into from
Aug 28, 2026
+30 −2
Merged

[MINOR][CI] Stop unrelated PR comments from cancelling Delta and ANSI runs #12906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c0a09b
ci: only cancel the Delta Spark UT run for a real /delta-test comment
LuciferYang Aug 27, 2026
af5e68b
ci: give a non-command comment run its own concurrency group
LuciferYang Aug 27, 2026
0c1cb09
ci: append the discriminator only for a non-command comment run
LuciferYang Aug 27, 2026
74d189a
ci: say issue or PR comment, since review and commit comments use oth…
LuciferYang Aug 27, 2026
80c8660
ci: apply the same group discriminator to velox_backend_ansi.yml
LuciferYang Aug 27, 2026
c6a6777
ci: drop 32 now-passing entries from the Delta known-failures baseline
LuciferYang Aug 28, 2026
6eec515
Merge remote-tracking branch 'upstream/main' into delta-ut-comment-co…
LuciferYang Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/delta_spark_ut.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,24 @@ env:
DELTA_NUM_SHARDS: '8'

# Cancel older `pull_request` and `/delta-test` runs for the same PR.
#
# `issue_comment` fires on every comment posted on an issue or a PR, and
# `github.event.issue.number` is that issue's number, which for a comment on a
# PR is the PR's own number. Such a run would therefore join the PR's group and
# cancel an in-flight suite while `delta-test-requested` below skips it, losing
# the suite and replacing it with nothing. Give only that case a group of its
# own, so every other trigger keeps the exact group name it has today. The
# negated condition is that job's `if` verbatim.
Comment on lines 151 to +159
concurrency:
group: ${{ github.repository }}-${{ github.event.pull_request.number || github.event.issue.number || github.head_ref || github.sha }}-${{ github.workflow }}
group: >-
${{ github.repository }}-${{ github.event.pull_request.number || github.event.issue.number || github.head_ref || github.sha }}-${{ github.workflow }}${{
!(github.event_name != 'issue_comment' ||
(github.event.issue.pull_request &&
(github.event.comment.body == '/delta-test' ||
startsWith(github.event.comment.body, '/delta-test ') ||
startsWith(github.event.comment.body, format('/delta-test{0}', fromJSON('"\r"'))) ||
startsWith(github.event.comment.body, format('/delta-test{0}', fromJSON('"\n"'))))))
&& format('-comment-{0}', github.run_id) || '' }}
cancel-in-progress: true

jobs:
Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/velox_backend_ansi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,20 @@ env:
CCACHE_DIR: "${{ github.workspace }}/.ccache"
SPARK_ANSI_SQL_MODE: true

# `issue_comment` fires on every comment posted on an issue or a PR, and
# `github.event.issue.number` puts such a run in the same group as an in-flight
# ANSI run for that PR, so `cancel-in-progress` kills it while `check-comment`
# below skips the newcomer, leaving no replacement. Give only that case a group
# of its own, so every other trigger keeps the exact group name it has today.
# The negated condition is that job's `if` verbatim.
concurrency:
group: ${{ github.repository }}-ansi-${{ github.event.issue.number || inputs.pr_number }}
group: >-
${{ github.repository }}-ansi-${{ github.event.issue.number || inputs.pr_number }}${{
!((github.event_name == 'workflow_dispatch') ||
(github.event.issue.pull_request &&
(contains(github.event.comment.body, '/ansi-test') ||
contains(github.event.comment.body, '/ansi-analyze'))))
&& format('-comment-{0}', github.run_id) || '' }}
cancel-in-progress: true

jobs:
Expand Down
Loading