[GLUTEN-10134][VL] Remove redundant registerSparkCastModeSpecialForms call - #12816
Merged
philo-he merged 3 commits intoAug 19, 2026
Merged
Conversation
ReemaAlzaid
force-pushed
the
remove-redundant-cast-registration
branch
from
August 18, 2026 20:02
5141982 to
514a611
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Follow up to #12051, addressing a post-merge review comment from @philo-he:
#12051 (comment)... (link to the comment)
Velox's
sparksql::registerFunctions("")already registers the Spark cast modespecial forms internally (
registerFunctions→registerSpecialFormGeneralFunctions→
registerSparkCastModeSpecialForms), so the explicit call added in #12051 isredundant. This removes the call and the now-unused
SparkCastExpr.hinclude fromRegistrationAllFunctions.cc.How was this patch tested?
Existing CI
Was this patch authored or co-authored using generative AI tooling?
Related issue: #10134