Skip to content

[VL] Fix native SIGSEGV in ~ObjectStore when release() races with store destruction #12740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Aug 12, 2026
Merged

[VL] Fix native SIGSEGV in ~ObjectStore when release() races with store destruction #12740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cpp/core/utils/ObjectStore.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,13 @@ std::pair<gluten::ObjectStore*, gluten::ResourceHandle> gluten::ObjectStore::loo

gluten::ObjectStore::~ObjectStore() {
for (;;) {
if (aliveObjects_.empty()) {
break;
}
std::shared_ptr<void> tempObj;
{
const std::lock_guard<std::mutex> lock(mtx_);
// The empty-check and the pop of the last alive object must be atomic under `mtx_`.
if (aliveObjects_.empty()) {
break;
}
// destructing in reversed order (the last added object destructed first)
auto itr = aliveObjects_.rbegin();
const ResourceHandle handle = (*itr).first;
Expand Down
Loading