Skip to content

[VL] Fail fast when NativeMemoryManager.hold() is called after release() instead of a native SIGSEGV #12714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhztheplayer merged 1 commit into from
Aug 14, 2026
Merged

[VL] Fail fast when NativeMemoryManager.hold() is called after release() instead of a native SIGSEGV #12714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion gluten-arrow/src/main/scala/org/apache/gluten/memory/NativeMemoryManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,15 @@ object NativeMemoryManager {
private val released: AtomicBoolean = new AtomicBoolean(false)

override def addSpiller(spiller: Spiller): Unit = spillers.append(spiller)
override def hold(): Unit = NativeMemoryManagerJniWrapper.hold(handle)
override def hold(): Unit = {
// hold() must run before release(). Reaching here after release means a broken teardown
// ordering, so surface it instead of dereferencing a freed native handle silently.
if (released.get()) {
throw new GlutenException(
s"Cannot hold memory manager instance that has already been released: $handle")
}
NativeMemoryManagerJniWrapper.hold(handle)
}
override def getHandle(): Long = handle
override def release(): Unit = {
if (!released.compareAndSet(false, true)) {
Expand Down
Loading