[VL] Install Flex under /usr in CentOS 7 vcpkg images#12627
Open
baibaichen wants to merge 1 commit into
Open
Conversation
Keep the required Flex 2.6.4 build while placing its executable and headers outside the /usr/local prefix isolated by vcpkg builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 81cd27bb-c736-4cf5-b65f-2aeb9f954996
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CentOS 7 vcpkg build-dep bootstrap script so the source-built Flex 2.6.4 is installed under /usr (instead of the default /usr/local), aligning with upcoming work to isolate vcpkg builds from /usr/local while keeping a Flex version compatible with Velox’s lexer shim.
Changes:
- Change the Flex 2.6.4
./configureinvocation to install under/usron CentOS 7.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
114
to
+116
| cd /tmp/flex | ||
| ./autogen.sh | ||
| ./configure | ||
| ./configure --prefix=/usr |
zhouyuan
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This is a prerequisite for #12625.
Install the source-built Flex 2.6.4 under
/usrin the CentOS 7 vcpkg build environment. PR #12625 isolates vcpkg builds from/usr/local, while the current image placesflexandFlexLexer.hunder that ignored prefix.CentOS 7's packaged Flex 2.5.37 is not compatible with the current Velox
YyFlexLexerShim, so this keeps Flex 2.6.4 and only changes its installation prefix. Once the image is rebuilt, #12625 can remove its temporary Flex path workaround.How was this patch tested?
bash -n dev/vcpkg/setup-build-depends.sh./usrbut fails to compile the current VeloxYyFlexLexerShim.Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot CLI 1.0.75