[VL] Fix password leak in debug-mode config logging - #12606
Merged
Conversation
printConfig() already had redaction logic keyed on spark.redaction.regex, but when that config key was absent (the common case) getRedactionRegex() returned std::nullopt and every config value — including passwords, tokens, and secrets — was logged in plain text. This patch adds a hard-coded default redaction pattern to guard on this case Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_improve_redaction_print
branch
from
July 23, 2026 09:38
7ba17f2 to
3c6c1c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch improved the redaction behavior in printConfig() by adding a default pattern
How was this patch tested?
new test added
Was this patch authored or co-authored using generative AI tooling?
IBM Bob