Skip to content

[VL] Include headers from INSTALL_PREFIX as system includes on Mac #12423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhouyuan merged 1 commit into from
Jul 24, 2026
Merged

[VL] Include headers from INSTALL_PREFIX as system includes on Mac #12423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ep/build-velox/src/build-velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,12 @@ function compile {
if [[ "$(uname)" == "Darwin" ]]; then
CXX_FLAGS="$CXX_FLAGS -Wno-inconsistent-missing-override -Wno-macro-redefined"
if [[ -n "${INSTALL_PREFIX:-}" && "${INSTALL_PREFIX:-}" != "/usr/local" && "${INSTALL_PREFIX:-}" != /usr/local/* ]]; then
# Some prefix-installed deps only publish loose headers (e.g. xsimd), so
# keep the prefix include dir on the compiler command line.
CXX_FLAGS="$CXX_FLAGS -I${INSTALL_PREFIX}/include"
# Add the dependency prefix as a system include: this finds deps that only
# publish loose headers (e.g. xsimd) and demotes warnings in vendored
# dependency headers (abseil's __is_trivially_relocatable, arrow's vendored
# date.h literal operators) to non-fatal system-header warnings under
# -Werror on recent clang.
CXX_FLAGS="$CXX_FLAGS -isystem ${INSTALL_PREFIX}/include"
fi
fi

Expand Down
Loading