[GLUTEN-11539][VL] Improve error message when spark.io.compression.codec=none#12360
Open
brijrajk wants to merge 1 commit into
Open
[GLUTEN-11539][VL] Improve error message when spark.io.compression.codec=none#12360brijrajk wants to merge 1 commit into
brijrajk wants to merge 1 commit into
Conversation
…dec=none Follow-up to apache#12333. When spark.io.compression.codec is set to none, the previous error message told users to configure spark.gluten.sql.columnar.shuffle.codec, which is misleading if the intent is to disable compression. Special-case none to also point users to spark.shuffle.compress=false, which is the correct knob to disable Gluten native shuffle compression (handled in ColumnarShuffleWriter and ColumnarBatchSerializer).
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Follow-up to #12333.
When
spark.io.compression.codec=none, the error message from #12333 told users to configurespark.gluten.sql.columnar.shuffle.codec, which is misleading if their intent is to disable shuffle compression.noneis special-cased to also point users tospark.shuffle.compress=false, which is the correct knob for disabling Gluten native shuffle compression (already handled inColumnarShuffleWriterandColumnarBatchSerializer).Before (from #12333):
After:
Files changed
GlutenShuffleUtils.scala— special-casesnonewith a more actionable error messageMiscOperatorSuite.scala— updates thenoneregression test assertion to matchHow was this patch tested?
MiscOperatorSuite— 97/97 passed locally (Spark 4.0, Velox backend).Was this patch authored or co-authored using generative AI tooling?
Yes. Claude Code (claude-sonnet-4-6) was used as an AI assistant during development.
Related issue: #11539