Skip to content

[GLUTEN-10992][VL] Fix MatchError for KeyGroupedPartitioning in native shuffle #12335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brijrajk wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

[GLUTEN-10992][VL] Fix MatchError for KeyGroupedPartitioning in native shuffle #12335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,12 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi with Logging {
}
}
}
case _: KeyGroupedPartitioning =>
FallbackTags.add(
shuffle,
ValidationResult.failed(
"KeyGroupedPartitioning is not supported by Gluten native shuffle"))
shuffle.withNewChildren(child :: Nil)
case _ =>
ColumnarShuffleExchangeExec(shuffle, child, null)
}
Expand Down
4 changes: 4 additions & 0 deletions backends-velox/src/main/scala/org/apache/spark/sql/execution/utils/ExecUtil.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.apache.spark.sql.execution.utils
import org.apache.gluten.backendsapi.BackendsApiManager
import org.apache.gluten.columnarbatch.{ColumnarBatches, VeloxColumnarBatches}
import org.apache.gluten.config.ShuffleWriterType
import org.apache.gluten.exception.GlutenNotSupportException
import org.apache.gluten.iterator.Iterators
import org.apache.gluten.memory.arrow.alloc.ArrowBufferAllocators
import org.apache.gluten.runtime.Runtimes
Expand Down Expand Up @@ -172,6 +173,9 @@ object ExecUtil {
// range partitioning fall back to row-based partition id computation
case RangePartitioning(orders, n) =>
new NativePartitioning(GlutenShuffleUtils.RangePartitioningShortName, n)
case other =>
throw new GlutenNotSupportException(
s"Partitioning ${other.getClass.getSimpleName} is not supported by native shuffle")
}

val isRoundRobin = newPartitioning.isInstanceOf[RoundRobinPartitioning] &&
Expand Down
Loading