[VL] Simplify lifecycle of NativeMemoryManager and NativeThreadManager#12323
Open
zhztheplayer wants to merge 3 commits into
Open
[VL] Simplify lifecycle of NativeMemoryManager and NativeThreadManager#12323zhztheplayer wants to merge 3 commits into
zhztheplayer wants to merge 3 commits into
Conversation
The patch simplifies lifecycles of nmm and ntm, they are now released in `RuntimeImpl.released()`, and no longer by managed by the task resource registry.
zhztheplayer
force-pushed
the
wip-fix-lifecycle
branch
from
522abad to
ad40059
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Simplifies the lifecycle management of NativeMemoryManager (nmm) and NativeThreadManager (ntm) by removing Spark TaskResources integration and releasing both explicitly from RuntimeImpl.release().
Changes:
- Remove
TaskResource/TaskResourcesregistration for NTM and NMM. - Add explicit
release()APIs and invoke them fromRuntimeImpl.release(). - Adjust logging/error messages to no longer reference Spark task resource metadata.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gluten-arrow/src/main/scala/org/apache/gluten/threads/NativeThreadManager.scala | Removes Spark task resource registration; adds explicit release() responsibility to caller. |
| gluten-arrow/src/main/scala/org/apache/gluten/runtime/Runtime.scala | Releases NTM/NMM from RuntimeImpl.release() instead of relying on task resources. |
| gluten-arrow/src/main/scala/org/apache/gluten/memory/NativeMemoryManager.scala | Removes Spark task resource registration; adds release() to trait and adjusts release-time logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch simplifies lifecycles of nmm and ntm, so they are now released in
RuntimeImpl.release(), and no longer managed by the task resource registry.