[MINOR] Refactor operator-enable configs and remove dead code#12212
Open
philo-he wants to merge 2 commits into
Open
[MINOR] Refactor operator-enable configs and remove dead code#12212philo-he wants to merge 2 commits into
philo-he wants to merge 2 commits into
Conversation
|
Run Gluten Clickhouse CI on x86 |
philo-he
changed the title
enableColumnarXxx naming and remove dead code
|
Run Gluten Clickhouse CI on x86 |
philo-he
changed the title
enableColumnarXxx naming and remove dead code
philo-he
changed the title
|
Run Gluten Clickhouse CI on x86 |
marin-ma
reviewed
Jun 2, 2026
| buildConf("spark.gluten.sql.broadcastNestedLoopJoinTransformerEnabled") | ||
| .doc("Config to enable BroadcastNestedLoopJoinExecTransformer.") | ||
| val COLUMNAR_BROADCAST_NESTED_LOOP_JOIN_ENABLED = | ||
| buildConf("spark.gluten.sql.columnar.broadcastNestedLoopJoin") |
Contributor
There was a problem hiding this comment.
We should update the docs along with the configuration naming changes
I noticed that the current names are inconsistent for the operator-level enablement configurations. Maybe we can unify the naming using a fixed pattern, such as spark.gluten.sql.columnar.xxx.enabled?
Member
Author
There was a problem hiding this comment.
@marin-ma, thank you so much for the review. I just updated the PR according to your comment. Could you take a look again when you get a chance? Thank you.
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
supportExpandExec()from BackendSettingsApi — both backends (Velox and ClickHouse) return true, making the check in ExpandExecTransformer dead code.BroadcastNestedLoopJoinExecTransformer.doValidateInternal()—Validators.scalaalready gates on the same config before the transformer is ever created.cartesianProductTransformerEnabled / broadcastNestedLoopJoinTransformerEnabledtoenableColumnarCartesianProduct / enableColumnarBroadcastNestedLoopJointo follow the established enableColumnarXxx naming convention. Also fixes the TransformerTransformer typo in the original name.How was this patch tested?
Relies on CI verification.
Was this patch authored or co-authored using generative AI tooling?
No.