[VL][Delta] Add DV scan info extraction utility#12197
Merged
zhztheplayer merged 3 commits intoJun 3, 2026
Merged
Conversation
This was referenced Jun 1, 2026
zhztheplayer
reviewed
Jun 2, 2026
Comment on lines
+45
to
+46
| descriptor: Option[DeletionVectorDescriptor], | ||
| serializedDeletionVector: Array[Byte]) { |
Member
There was a problem hiding this comment.
As we are passing a serialized deletion vector to C++, why do we need to preserve the original DeletionVectorDescriptor alongside?
Contributor
Author
There was a problem hiding this comment.
Good point @zhztheplayer , I removed DeletionVectorDescriptor from the exported scan info and only keep it locally while materializing the serialized DV payload.
zhztheplayer
approved these changes
Jun 2, 2026
Comment on lines
+43
to
+47
| final case class DeletionVectorInfo( | ||
| rowIndexFilterType: RowIndexFilterType, | ||
| hasDeletionVector: Boolean, | ||
| cardinality: Long, | ||
| serializedDeletionVector: Array[Byte]) |
Member
There was a problem hiding this comment.
nit: can we reorder to place hasDeletionVector as the first field?
Contributor
Author
There was a problem hiding this comment.
Thanks @zhztheplayer! Will reorder hasDeletionVector first in both Delta 3.3 and Delta 4.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR is the next split from the Delta deletion-vector (DV) scan stack, following the native reader support already merged in #12040 and before the full JVM scan handoff work from #12131.
It adds a focused Scala utility layer that extracts the essential DV scan information from Spark/Delta
PartitionedFilemetadata without changing scan offload behavior yet.Main changes:
DeltaDeletionVectorScanInfofor Delta 3.3 and Delta 4.0 source setsPartitionedFilemetadata:This PR is intentionally utility-only:
Those pieces stay in follow-up PRs after this API is reviewed.
How was this patch tested?
Validation run:
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./build/mvn test-compile -pl backends-velox -am -Pjava-17,spark-3.5,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsJAVA_HOME=$(/usr/libexec/java_home -v 17) ./build/mvn test-compile -pl backends-velox -am -Pjava-17,spark-4.0,scala-2.13,backends-velox,hadoop-3.3,spark-ut,delta -DskipTestsgit diff --checkAlso attempted the focused suite with
dev/run-scala-test.sh, but the local runner failed during classpath compilation before executing the suite while switching profiles locally. The module-level Spark 3.5 and Spark 4.0 test-compile checks above pass.Was this patch authored or co-authored using generative AI tooling?
Generated-by: IBM BOB