[GLUTEN-12053][CELEBORN] Bump Celeborn version to 0.6.3 #12057
+73
−10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -700,4 +700,54 @@ public static void stopFailedShuffleCleaner(Object failedShuffleCleaner) { | |
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| public static void prepareForMergeData( | ||
| ShuffleClient shuffleClient, int shuffleId, int mapId, int attemptId) { | ||
| try { | ||
| Method prepareMethod = | ||
| shuffleClient | ||
| .getClass() | ||
| .getDeclaredMethod("prepareForMergeData", Integer.TYPE, Integer.TYPE, Integer.TYPE); | ||
| prepareMethod.invoke(shuffleClient, shuffleId, mapId, attemptId); | ||
| } catch (NoSuchMethodException ignored) { | ||
|
Contributor
There was a problem hiding this comment. should we have a warning for this?
Member
Author
There was a problem hiding this comment. @jackylee-ch, it's unnecessary to log warning for this. This interface is removed from 0.6.3. In addtion, other method invokers also do not log warning for |
||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| public static void mapperEnd( | ||
| ShuffleClient shuffleClient, | ||
| int shuffleId, | ||
| int mapId, | ||
| int attemptId, | ||
| int numMappers, | ||
| int numPartitions) { | ||
| try { | ||
| try { | ||
| // for Celeborn 0.6.3 | ||
| Method mapperEndMethod = | ||
| shuffleClient | ||
| .getClass() | ||
| .getDeclaredMethod( | ||
| "mapperEnd", | ||
| Integer.TYPE, | ||
| Integer.TYPE, | ||
| Integer.TYPE, | ||
| Integer.TYPE, | ||
| Integer.TYPE); | ||
| mapperEndMethod.invoke( | ||
| shuffleClient, shuffleId, mapId, attemptId, numMappers, numPartitions); | ||
| } catch (NoSuchMethodException e) { | ||
| Method mapperEndMethod = | ||
| shuffleClient | ||
| .getClass() | ||
| .getDeclaredMethod( | ||
| "mapperEnd", Integer.TYPE, Integer.TYPE, Integer.TYPE, Integer.TYPE); | ||
| mapperEndMethod.invoke(shuffleClient, shuffleId, mapId, attemptId, numMappers); | ||
| } | ||
| } catch (NoSuchMethodException ignored) { | ||
|
|
||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should cache reflection methods to avoid creating them on every call.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wForget, this improvement would be implemented in another pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create an issue to track this first?