Skip to content

[GLUTEN-8232][VL] Allow to enable dynamic openssl link in VCPKG packaging #11444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhouyuan wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[GLUTEN-8232][VL] Allow to enable dynamic openssl link in VCPKG packaging #11444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
44b6235
[VL] enable dynamic openssl in vcpkg
zhouyuan Jan 19, 2026
f7e9cdd
refactor
zhouyuan May 25, 2026
8b8d3f5
adding arm support
zhouyuan May 25, 2026
3116f64
refine
zhouyuan May 25, 2026
30980cd
remove deprecated file
zhouyuan May 25, 2026
d02e9b4
Revert "remove deprecated file"
zhouyuan May 25, 2026
3289a34
fix
zhouyuan May 25, 2026
357869b
merge with original cmake
zhouyuan May 25, 2026
422fe94
skip copying libs
zhouyuan May 26, 2026
baf5225
add test
zhouyuan May 26, 2026
dcf9816
Revert "add test"
zhouyuan May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/velox_backend_x86.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
ccache-centos7-release-default
- name: Build Gluten native libraries
run: |
docker pull apache/gluten:vcpkg-centos-7-gcc13
docker run -v $GITHUB_WORKSPACE:/work -w /work apache/gluten:vcpkg-centos-7-gcc13 bash -c "
set -e
yum install tzdata -y
Expand Down
11 changes: 8 additions & 3 deletions dev/vcpkg/init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ if [ "$ENABLE_GCS" = "ON" ]; then
EXTRA_FEATURES+="--x-feature=velox-gcs "
fi
if [ "$ENABLE_ABFS" = "ON" ]; then
EXTRA_FEATURES+="--x-feature=velox-abfs"
EXTRA_FEATURES+="--x-feature=velox-abfs "
fi
if [ "${VCPKG_DYNAMIC_OPENSSL:-OFF}" = "ON" ]; then
EXTRA_FEATURES+="--x-feature=dynamic-openssl "
fi


Expand All @@ -97,7 +100,9 @@ $VCPKG install --no-print-usage \
# needed by 'releases/libvelox.so'
mkdir -p $VCPKG_TRIPLET_INSTALL_DIR/debug/lib/
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/libz.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/libssl.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/libcrypto.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
if [ "${VCPKG_DYNAMIC_OPENSSL:-OFF}" = "OFF" ]; then
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/libssl.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/libcrypto.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
fi
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/liblzma.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
cp $VCPKG_TRIPLET_INSTALL_DIR/lib/libdwarf.a $VCPKG_TRIPLET_INSTALL_DIR/debug/lib
4 changes: 4 additions & 0 deletions dev/vcpkg/triplets/arm64-linux-neon.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Linux)
set(VCPKG_C_FLAGS "-march=armv8-a+crc")
set(VCPKG_CXX_FLAGS "-march=armv8-a+crc -std=c++20")
set(VCPKG_LINKER_FLAGS "-static-libstdc++ -static-libgcc")

if("${PORT}" STREQUAL "openssl" AND "$ENV{VCPKG_DYNAMIC_OPENSSL}" STREQUAL "ON")
set(VCPKG_LIBRARY_LINKAGE dynamic)
endif()
4 changes: 4 additions & 0 deletions dev/vcpkg/triplets/x64-linux-avx.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ set(VCPKG_LINKER_FLAGS "-static-libstdc++ -static-libgcc")
if("${PORT}" STREQUAL "snappy")
list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS -DSNAPPY_HAVE_BMI2=ON)
endif()

if("${PORT}" STREQUAL "openssl" AND "$ENV{VCPKG_DYNAMIC_OPENSSL}" STREQUAL "ON")
set(VCPKG_LIBRARY_LINKAGE dynamic)
endif()
9 changes: 9 additions & 0 deletions dev/vcpkg/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@
"grpc"
]
},
"dynamic-openssl": {
"description": "Enable dynamic OpenSSL with fips feature",
"dependencies": [
{
"name": "openssl",
"features": ["fips"]
}
]
},
"velox-s3": {
"description": "Velox S3 Support",
"dependencies": [
Expand Down
Loading