[VL] Include headers from INSTALL_PREFIX as system includes on Mac#12423
Merged
Conversation
Member
|
@kevinwilfong thanks, please check if this fix from @jackylee-ch works |
Collaborator
Author
|
Looks like it fixes it, closing this out. |
kevinwilfong
force-pushed
the
velox-system-include
branch
from
July 21, 2026 23:08
c03c85b to
2459258
Compare
Collaborator
Author
|
@zhouyuan I'm reopening this PR, I had visibly spot checked the PR you referenced and it looked like it fixed the issue, but because it uses -I instead of -isystem I ran into this issue again when I tried to do a build in a fresh checkout. Could you please take a look? |
zhouyuan
approved these changes
Jul 22, 2026
Collaborator
Author
|
@zhouyuan thanks for the review! could you help me to merge the change, I'm afraid I don't have permissions. |
jackylee-ch
approved these changes
Jul 23, 2026
zhouyuan
added a commit
to zhouyuan/gluten
that referenced
this pull request
Jul 24, 2026
…pache#12423)" This reverts commit a9638bf.
Member
|
@kevinwilfong it looks like this patch will break the macos build: the system level fmt will be picked instead of the one under INSTALL_PREFIX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
#12105 introduced the flag -DCMAKE_NO_SYSTEM_FROM_IMPORTED=ON to Velox builds. This has the unintended side effect of including dependencies' header files as non-system includes which means that warnings in the build are promoted to errors, e.g.
To fix this, this PR proposes explicitly including the header files under ${INSTALL_PREFIX}/include from dependencies as system includes, suppressing these errors which we have limited control over.
How was this patch tested?
Executed ./dev/builddeps-veloxbe.sh on a Mac with Clang 21, verified we no longer got errors from warnings in dependencies. Combined with my other recent changes
#12421
#12422
I was able to successfully run ./dev/builddeps-veloxbe.sh on an otherwise fresh checkout.
Was this patch authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8
Generated-by: Claude Opus 4.8