[docs] Fix version-replace plugin path split on Windows#3517
Open
GabrielBBaldez wants to merge 1 commit into
Open
[docs] Fix version-replace plugin path split on Windows#3517GabrielBBaldez wants to merge 1 commit into
GabrielBBaldez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3516
The documentation website build fails on Windows because the
remark-version-replaceplugin does not substitute version placeholders.Brief change log
getDocsVersionName()now splits the file path on both/and\, so the docs version is detected on Windows as well as on POSIX. Previously it split on'/'only, so on Windows (vfile.pathuses\) it returned'', leaving$FLUSS_VERSION$/$FLUSS_MAVEN_REPO_URL$etc. unsubstituted and failing the broken-links check (~24 broken links to a literal$FLUSS_MAVEN_REPO_URL$/...).Tests
Built the website locally on Windows (
npm run clear && npm run build): before the fix, ~24 broken links; after, 0. No change on POSIX — the character class/[/\]/is equivalent to/when the path contains no backslashes.Generative AI disclosure
Generated-by: Claude Code (Opus 4.8) following the guidelines