[metrics] Add database and table labels for scanner metrics#565
Merged
Conversation
Contributor
Author
|
@fresh-borzoni @leekeiabstraction PTAL 🙏 thanks! |
leekeiabstraction
approved these changes
May 26, 2026
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #563
Brief change log
Scanner metrics are emitted globally, a client process scanning more than one table aggregates every metric into a single
time series, with no way to attribute fetch latency, byte volume, or poll-timing to a specific table.
this PR adds new ScannerMetrics struct caches the scanner-metric handles with database and table labels.
Tests
API and Format
Documentation