fix: add missing write_array impl to IcebergBinaryRowWriter#477
Merged
leekeiabstraction merged 1 commit intoApr 5, 2026
Merged
Conversation
The BinaryWriter trait gained a write_array method but the IcebergBinaryRowWriter impl was not updated, causing a build failure. Array values are unsupported as Iceberg bucket keys, so the method panics with a clear message, consistent with set_null_at.
Contributor
Author
|
@fresh-borzoni Appreciate if you can review this small PR to fix CI failure on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinaryWritertrait gained awrite_arraymethod (from the array data type support PR feat: Add array data type support #433), butIcebergBinaryRowWriterwas not updated, causing a build failure on main.write_arrayimplementation that panics with a clear message, since array values are unsupported as Iceberg bucket keys (consistent withset_null_atand the existingcreate_value_writerrejection).Test plan
cargo build --workspace --all-targetspassescargo test --workspace— all 312 unit tests pass