Skip to content

chore: make get admin sync#450

Merged
luoyuxia merged 1 commit into
apache:mainfrom
luoyuxia:make_get_admin_sync
Mar 23, 2026
Merged

chore: make get admin sync#450
luoyuxia merged 1 commit into
apache:mainfrom
luoyuxia:make_get_admin_sync

Conversation

@luoyuxia

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: close #xxx

Brief change log

Tests

API and Format

Documentation

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes get_admin a synchronous (non-async) accessor on the Fluss connection, and updates documentation, examples, bindings, and integration tests to match the new API shape.

Changes:

  • Change Rust FlussConnection::get_admin from async to synchronous, returning a cached admin client.
  • Update Rust/Python user-guide docs and examples to remove await for get_admin.
  • Update Rust integration tests and Python/C++ bindings/tests to use the synchronous get_admin.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
website/docs/user-guide/rust/example/partitioned-tables.md Update Rust example to call get_admin() synchronously.
website/docs/user-guide/rust/example/log-tables.md Update Rust example to call get_admin() synchronously.
website/docs/user-guide/rust/example/index.md Update Rust quickstart to call get_admin() synchronously.
website/docs/user-guide/rust/example/admin-operations.md Update Rust snippet to call get_admin() synchronously.
website/docs/user-guide/rust/error-handling.md Update Rust error-handling examples to call get_admin() synchronously.
website/docs/user-guide/rust/api-reference.md Document get_admin as synchronous.
website/docs/user-guide/python/example/log-tables.md Update Python example to call get_admin() synchronously.
website/docs/user-guide/python/example/index.md Update Python quickstart to call get_admin() synchronously.
website/docs/user-guide/python/example/admin-operations.md Update Python snippet to call get_admin() synchronously.
website/docs/user-guide/python/api-reference.md Document get_admin as synchronous in Python API table.
crates/fluss/tests/integration/table_remote_scan.rs Update integration test to remove .await from get_admin.
crates/fluss/tests/integration/sasl_auth.rs Update SASL integration tests to remove .await from get_admin.
crates/fluss/tests/integration/log_table.rs Update log table integration tests to remove .await from get_admin.
crates/fluss/tests/integration/kv_table.rs Update KV table integration tests to remove .await from get_admin.
crates/fluss/tests/integration/admin.rs Update admin integration tests to remove .await from get_admin.
crates/fluss/src/lib.rs Update crate-level docs example to call get_admin() synchronously.
crates/fluss/src/client/table/scanner.rs Update doc comments/examples to call get_admin() synchronously.
crates/fluss/src/client/connection.rs Change get_admin to a synchronous cached accessor.
crates/fluss/README.md Update README example to call get_admin() synchronously.
crates/examples/src/example_table.rs Update Rust example to call get_admin() synchronously.
crates/examples/src/example_partitioned_kv_table.rs Update Rust example to call get_admin() synchronously.
crates/examples/src/example_kv_table.rs Update Rust example to call get_admin() synchronously.
bindings/python/test/test_sasl_auth.py Update Python tests to call get_admin() synchronously.
bindings/python/test/conftest.py Update fixtures/helpers to call get_admin() synchronously.
bindings/python/src/table.rs Update binding code to use synchronous get_admin().
bindings/python/src/connection.rs Change Python binding get_admin to a synchronous method returning FlussAdmin.
bindings/python/fluss/init.pyi Update type stub to make get_admin synchronous.
bindings/python/example/example.py Update Python example to call get_admin() synchronously.
bindings/cpp/src/lib.rs Update C++ FFI wrapper to call synchronous get_admin().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread website/docs/user-guide/rust/api-reference.md Outdated
@luoyuxia luoyuxia force-pushed the make_get_admin_sync branch from c44c8ed to 1c763e8 Compare March 23, 2026 02:08
@luoyuxia luoyuxia force-pushed the make_get_admin_sync branch from 1c763e8 to dc01b19 Compare March 23, 2026 02:17
@luoyuxia luoyuxia merged commit da021ad into apache:main Mar 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants