Skip to content

chore: fix mut schema builder public api #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luoyuxia merged 2 commits into from
Mar 3, 2026
Merged

chore: fix mut schema builder public api #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e70c3bf
chore: fix mut schema builder public api
fresh-borzoni Mar 3, 2026
349875c
fix clippy warning
fresh-borzoni Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/examples/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ path = "src/example_kv_table.rs"

[[example]]
name = "example-partitioned-upsert-lookup"
path = "src/example_partitioned_kv_table.rs"
path = "src/example_partitioned_kv_table.rs"
6 changes: 3 additions & 3 deletions crates/fluss/src/metadata/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,8 @@ impl SchemaBuilder {
Ok(self)
}

pub fn build(&mut self) -> Result<Schema> {
let columns = Self::normalize_columns(&mut self.columns, self.primary_key.as_ref())?;
pub fn build(&self) -> Result<Schema> {
let columns = Self::normalize_columns(&self.columns, self.primary_key.as_ref())?;

let column_names: HashSet<_> = columns.iter().map(|c| &c.name).collect();
for auto_inc_col in &self.auto_increment_col_names {
Expand Down Expand Up @@ -266,7 +266,7 @@ impl SchemaBuilder {
}

fn normalize_columns(
columns: &mut [Column],
columns: &[Column],
primary_key: Option<&PrimaryKey>,
) -> Result<Vec<Column>> {
let names: Vec<_> = columns.iter().map(|c| &c.name).collect();
Expand Down
2 changes: 1 addition & 1 deletion crates/fluss/src/test_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use std::sync::Arc;

pub(crate) fn build_table_info(table_path: TablePath, table_id: i64, buckets: i32) -> TableInfo {
let row_type = DataTypes::row(vec![DataField::new("id", DataTypes::int(), None)]);
let mut schema_builder = Schema::builder().with_row_type(&row_type);
let schema_builder = Schema::builder().with_row_type(&row_type);
let schema = schema_builder.build().expect("schema build");
let table_descriptor = TableDescriptor::builder()
.schema(schema)
Expand Down
Loading