[TASK-383] Error Handling fix CPP, for pointer returning methods#409
Merged
Conversation
Member
Author
There was a problem hiding this comment.
Pull request overview
This PR updates the C++ ↔ Rust CXX bridge for pointer-returning APIs to preserve server-side error codes by returning an intermediate FfiPtrResult (instead of Result<*mut T> which collapses errors to string-only rust::Error).
Changes:
- Introduces
FfiPtrResult { result: FfiResult, ptr: ... }in the Rust CXX bridge and updates pointer-returning Rust APIs to use it. - Updates C++ wrappers (connection/table/writer creation + write calls) to decode
FfiResultand extract the returned pointer on success. - Adjusts
WriteResultdestruction to use an explicit Rust-side deleter (delete_write_result).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| bindings/cpp/src/lib.rs | Adds FfiPtrResult, helper constructors, updates multiple Rust FFI exports to return it, and adds delete_write_result. |
| bindings/cpp/src/connection.cpp | Switches connection/admin/table getters to consume FfiPtrResult and preserve error codes. |
| bindings/cpp/src/table.cpp | Switches writer/scanner/lookuper creation and write calls to consume FfiPtrResult; updates WriteResult drop path. |
| bindings/cpp/src/ffi_converter.hpp | Adds ptr_from_ffi helper to convert FfiPtrResult.ptr to typed pointers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Addressed comments |
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
TY for the PR, left a comment. PTAL
Member
Author
|
@leekeiabstraction Ty for the review |
luoyuxia
approved these changes
Mar 3, 2026
luoyuxia
left a comment
Contributor
There was a problem hiding this comment.
@fresh-borzoni Thanks. Merging..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #383
Replaces CXX
Result<*mut T>bridge signatures withFfiPtrResultstruct to preserve server error codes that were previously lost when CXX converted Rust errors intorust::Error(string-only)