-
Notifications
You must be signed in to change notification settings - Fork 43
[TASK-331] Scan results returned per bucket python/cpp #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luoyuxia
merged 6 commits into
apache:main
from
fresh-borzoni:results_per_buckets-cpp-python
Feb 20, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ee38ad
[TASK-331] Scan results returned per bucket python/cpp
fresh-borzoni 8544604
add slicing/indexing test
fresh-borzoni 19b1108
fix doc
fresh-borzoni 065a96e
switch to IndexMap
fresh-borzoni 5d9a17f
Address comments
fresh-borzoni 2e41f23
change bucket view to match, introduce ScanData
fresh-borzoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this has been merged, after thinking about it again, I'd still like to discuss the naming since it's a public user-facing API. BucketView gives me the impression that it's a view of a bucket, but it's actually a bundle of records belonging to a bucket. So I'm wondering whether
BucketRecordswould be a more intuitive name? What do you think? @fresh-borzoniThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luoyuxia Yes, it's a better name after the changes. I'll rename, ty