feat: support unsubscribe partition#257
Merged
Merged
Conversation
Contributor
Author
|
@AndreaBozzo Could you please help review it. |
There was a problem hiding this comment.
Pull request overview
This PR adds support for unsubscribing from partition buckets in the log scanner, addressing issue #254. The implementation provides a way to dynamically remove partition buckets from active scanning, complementing the existing subscribe_partition functionality.
Changes:
- Added
unsubscribe_partitionmethod to remove partition buckets from active log scanning - Implemented proper validation to ensure the operation is only allowed on partitioned tables
- Extended C++ bindings to expose the new functionality to C++ clients
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/fluss/src/client/table/scanner.rs | Implements core unsubscribe_partition logic in LogScannerInner and exposes it through LogScanner and RecordBatchLogScanner public APIs |
| bindings/cpp/src/lib.rs | Adds FFI bridge function to expose unsubscribe_partition to C++ through the CXX interface |
| bindings/cpp/src/table.cpp | Implements C++ wrapper method that calls the Rust FFI function and handles availability checks |
| bindings/cpp/include/fluss.hpp | Declares public C++ API method signature for UnsubscribePartition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
force-pushed
the
unsubscribe-partition
branch
from
eda45e8 to
bf97f9a
Compare
luoyuxia
force-pushed
the
unsubscribe-partition
branch
from
bf97f9a to
a246f53
Compare
AndreaBozzo
reviewed
Feb 6, 2026
| err_result(1, "LogScanner not initialized".to_string()) | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
i cheked subscribe partition delegates to the consolidated do_subscribe helper. Maybe we can plan a similar helper going forward?
this LGTM tho and its not strictly needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #254
Brief change log
Tests
API and Format
Documentation