Skip to content

chore: rename subscribe_batch to subscribe_buckets#255

Merged
luoyuxia merged 1 commit into
apache:mainfrom
luoyuxia:rename-subscribe-batch
Feb 5, 2026
Merged

chore: rename subscribe_batch to subscribe_buckets#255
luoyuxia merged 1 commit into
apache:mainfrom
luoyuxia:rename-subscribe-batch

Conversation

@luoyuxia
Copy link
Copy Markdown
Contributor

@luoyuxia luoyuxia commented Feb 5, 2026

Purpose

Linked issue: close #253

Brief change log

Tests

API and Format

Documentation

@luoyuxia
Copy link
Copy Markdown
Contributor Author

luoyuxia commented Feb 5, 2026

@fresh-borzoni Please help review it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the method subscribe_batch to subscribe_buckets across the Rust codebase and C++ bindings to avoid confusion with "record batch" terminology. The change improves API clarity by ensuring that "batch" terminology is reserved for record batches rather than collections of bucket subscriptions.

Changes:

  • Renamed subscribe_batch method to subscribe_buckets in scanner implementation and public APIs
  • Updated error messages to reflect the new method name
  • Updated all call sites in tests, examples, and C++ bindings

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/fluss/tests/integration/log_table.rs Updated test to use the renamed subscribe_buckets method
crates/fluss/src/client/table/scanner.rs Renamed internal and public subscribe_batch methods to subscribe_buckets in LogScannerInner, LogScanner, and RecordBatchLogScanner, including error message update
bindings/cpp/src/table.cpp Updated C++ binding to call the renamed subscribe_buckets FFI method
bindings/cpp/src/lib.rs Renamed FFI bridge methods from subscribe_batch to subscribe_buckets
bindings/cpp/examples/example.cpp Updated example code error check string to reference subscribe_buckets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@fresh-borzoni fresh-borzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luoyuxia TY for the PR. LGTM. I'll rename in python bindings as well then.

@luoyuxia luoyuxia merged commit 52dca9f into apache:main Feb 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename subscribe_batch to subscribe_buckets

3 participants