feat: support scan from oss#217
Merged
Merged
Conversation
luoyuxia
commented
Jan 27, 2026
| [features] | ||
| default = ["storage-memory", "storage-fs", "storage-s3"] | ||
| storage-all = ["storage-memory", "storage-fs", "storage-s3"] | ||
| default = ["storage-memory", "storage-fs"] |
Contributor
Author
There was a problem hiding this comment.
remove storage-s3 from default which avoid oss users include it though they don't need.
| default = ["storage-memory", "storage-fs", "storage-s3"] | ||
| storage-all = ["storage-memory", "storage-fs", "storage-s3"] | ||
| default = ["storage-memory", "storage-fs"] | ||
| storage-all = ["storage-memory", "storage-fs", "storage-s3", "storage-oss"] |
Contributor
Author
There was a problem hiding this comment.
for s3 users:
fluss = { version = "x.x", features = ["storage-s3"] }
for oss users
fluss = { version = "x.x", features = ["storage-oss"] }
Contributor
Author
|
I'll verify it before ready to review. |
Contributor
Author
|
Already verify oss access @fresh-borzoni @leekeiabstraction @zhaohaidao Could you please help review this? |
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR, added one small comment
|
|
||
| assert!(convert_hadoop_key_to_opendal("fs.s3a.connection.ssl.enabled").is_none()); | ||
|
|
||
| // OSS keys |
Contributor
There was a problem hiding this comment.
Can we also add an assertion for access_key_secret in build_remote_fs_props_includes_all_fields()?
Contributor
Author
|
@leekeiabstraction Thanks for your review. Commments are addressed. |
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY Added small comment
| credentials.access_key_secret.clone(), | ||
| ); | ||
|
|
||
| // OSS specific configurations, todo: consider refactor it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #215
Brief change log
Tests
API and Format
Documentation