-
Notifications
You must be signed in to change notification settings - Fork 43
Introduce UpsertWriter #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bc89d21
UpsertWriterImpl
leekeiabstraction 8d61145
UpsertWriterImpl
leekeiabstraction 9810f2d
Kv Delete implementation
leekeiabstraction 9999622
Wire up sanity check
leekeiabstraction e10c7ce
Wire up table upsert
leekeiabstraction 3e07be5
Wire up table upsert
leekeiabstraction e866991
Address comments
leekeiabstraction e8984a5
Address comments
leekeiabstraction 5e9e7b0
UpsertWriter accepts InternalRow instead of CompactedRow
leekeiabstraction dbce85f
Only encode when not already encoded
leekeiabstraction 8e09eb9
Remove binary array copy when encoding is skipped while upserting
leekeiabstraction d6c672d
Remove unused import
leekeiabstraction 629ec3b
Add test cases
leekeiabstraction 7bb436c
Address comments
leekeiabstraction 8b38a84
Formatting
leekeiabstraction 2116179
Wire up bucketing in WriterClient
leekeiabstraction 7d829d9
Wire up bucketing in WriterClient
leekeiabstraction 41e03bd
Fix write batch instantiation and appending
leekeiabstraction File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use crate::error::Error::IllegalArgument; | ||
| use crate::error::Result; | ||
| use crate::metadata::{DataType, RowType}; | ||
| use crate::row::field_getter::FieldGetter; | ||
|
|
||
| #[allow(dead_code)] | ||
| pub struct PartitionGetter<'a> { | ||
| partitions: Vec<(&'a String, &'a DataType, FieldGetter)>, | ||
| } | ||
|
|
||
| #[allow(dead_code)] | ||
| impl<'a> PartitionGetter<'a> { | ||
| pub fn new(row_type: &'a RowType, partition_keys: &'a Vec<String>) -> Result<Self> { | ||
| let mut partitions = Vec::with_capacity(partition_keys.len()); | ||
|
|
||
| for partition_key in partition_keys { | ||
| if let Some(partition_col_index) = row_type.get_field_index(partition_key.as_str()) { | ||
| let data_type = &row_type | ||
| .fields() | ||
| .get(partition_col_index) | ||
| .unwrap() | ||
| .data_type; | ||
| let field_getter = FieldGetter::create(data_type, partition_col_index); | ||
|
|
||
| partitions.push((partition_key, data_type, field_getter)); | ||
| } else { | ||
| return Err(IllegalArgument { | ||
| message: format!( | ||
| "The partition column {partition_key} is not in the row {row_type}." | ||
| ), | ||
| }); | ||
| }; | ||
| } | ||
|
|
||
| Ok(Self { partitions }) | ||
| } | ||
|
|
||
| // TODO Implement get partition | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.