Improve log poll#103
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the log polling mechanism by introducing asynchronous fetch request handling with a buffering system. The changes enable pipelined fetching where new fetch requests can be sent while the client processes previously fetched data, improving throughput and reducing latency.
Key Changes
- Introduced
LogFetchBufferto manage pending and completed fetches with async notification support - Refactored
LogFetcherto spawn async tasks for fetch requests, enabling non-blocking parallel fetching - Changed
LogRecordsBatchesfrom borrowed to owned data (usingBytes) to support cross-task data sharing - Added
is_from_remoteflag toReadContextto handle projection differences between local and remote log reads
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/fluss/src/client/table/log_fetch_buffer.rs | New file implementing buffering system for log fetches with traits for pending/completed fetches |
| crates/fluss/src/client/table/scanner.rs | Refactored poll() to use timeout-based retry logic; send_fetches() spawns async tasks for parallel fetching |
| crates/fluss/src/client/table/remote_log.rs | Modified RemoteLogDownloadFuture to support completion callbacks; RemotePendingFetch implements PendingFetch trait |
| crates/fluss/src/record/arrow.rs | Removed lifetimes from LogRecordsBatches/LogRecordBatch; added remote read support in ReadContext |
| crates/fluss/src/client/credentials.rs | CredentialsCache now owns RpcClient and Metadata for simplified async usage |
| crates/fluss/tests/integration/table_remote_scan.rs | Added projection test and increased timeout to accommodate async fetching delays |
| crates/fluss/tests/integration/table.rs | Increased poll timeouts for integration tests |
| crates/fluss/src/client/table/mod.rs | Added log_fetch_buffer module |
| crates/fluss/Cargo.toml | Added scopeguard dependency for cleanup guards |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhaohaidao
reviewed
Dec 20, 2025
zhaohaidao
reviewed
Dec 20, 2025
Contributor
|
@luoyuxia Thanks for the pr. Left minor comments from resource management perspective. PTAL |
luoyuxia
force-pushed
the
improve-log-poll
branch
from
58cd526 to
9653f81
Compare
Contributor
Author
|
@zhaohaidao @leekeiabstraction Thanks for your review. Comments addressed now. PTAL |
Contributor
@LuoXia |
zhaohaidao
pushed a commit
to zhaohaidao/fluss-rust
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #94
Brief change log
Tests
API and Format
Documentation