[FLINK-38488][tests] Use 'throws Exception' instead of try-catch-fail…

[liuml07]

https://issues.apache.org/jira/browse/FLINK-38488

Currently we have some tests using following patter:

try {
  doTestSomething();
  ...
} catch (Exception e) {
  e.printStackTrace();
  fail(e.getMessage());
}

This can be replaced by just throwing Exceptions in test and let JUnit handles the failure along with exception stack trace. The existing code loses stack trace information in test reports, and we need to look around in the stdout to guess.

As we can see other tests in Flink uses the "throws Exception" model:

• The framework provides better formatting and integration with IDEs and CI systems
• Test runners can distinguish between assertion failures and unexpected exceptions
• Test logic is more readable without exception handling noise

[liuml07]

@ruanhang1993 I know you are tracking some testing improvements. Could you review this? Thanks,

[flinkbot]

CI report:

• a03933f Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[liuml07]

The testing failure seems unrelated as FLINK-38408 tracks the MapStateNullValueCheckpointingITCase which is not frequently reproducible. Meanwhile, e2e tests are failing with system error as in other builds.

[ruanhang1993]

LGTM. I think throw Exception is enough and better.

[ruanhang1993]

@liuml07 Could you rebase the master branch and re-run the CI? The e2e tests have been fixed. Thanks.

[ruanhang1993]

@flinkbot run azure

[liuml07]

I rebased again and it's still failing.

Failing tests in runtime module is tracked by FLINK-38223. E2E tests are failing with the old same panic: runtime error: invalid memory address or nil pointer dereference error

[liuml07]

The failing test testAdaptiveBatchScheduler in another module is irrelevant. The failing python module seems a different problem as well which fails in other CI runs.

[liuml07]

@ruanhang1993 do you think this PR is in a mergable shape, or we try more CI runs?