Skip to content

[FLINK-35405][runtime] Add metrics for AsyncExecutionController #25998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

fredia
Copy link
Contributor

@fredia fredia commented Jan 16, 2025

What is the purpose of the change

Add metrics for AsyncExecutionController.

Brief change log

  • Add metrics for AsyncExecutionController.
  • Add AEC section in metrics.md

Verifying this change

This change added tests and can be verified as follows:

  • AsyncExecutionControllerTest#testBasicRun()

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@fredia fredia marked this pull request as ready for review January 16, 2025 10:28
Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 16, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredia fredia merged commit 704b5c4 into apache:master Jan 19, 2025
ryanvanhuuksloot pushed a commit to ryanvanhuuksloot/flink that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants